Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15 seconds timeout #21085

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Sep 19, 2024

I am open-sourcing the Numpad1KeyTyped.java test.

I used CountDownLatch for synchronisation.

The test passes in CI.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15 seconds timeout (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21085/head:pull/21085
$ git checkout pull/21085

Update a local copy of the PR:
$ git checkout pull/21085
$ git pull https://git.openjdk.org/jdk.git pull/21085/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21085

View PR using the GUI difftool:
$ git pr show -t 21085

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21085.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2024

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 19, 2024

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15 seconds timeout

Reviewed-by: azvegint, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • fdc16a3: 8340480: Bad copyright notices in changes from JDK-8339902
  • 296b496: 8340353: Remove CompressedOops::ptrs_base
  • fde8508: 8339902: Open source couple TextField related tests
  • 75d5e11: 8340400: Shenandoah: Whitebox breakpoint GC requests may cause assertions
  • 15ae115: 8340166: [REDO] CDS: Trim down minimum GC region alignment
  • ec3cba0: 8340399: Update comment in SourceVersion for language evolution history
  • d1d8240: 8340308: PassFailJFrame: Make rows default to number of lines in instructions
  • bc36ace: 8340271: Open source several AWT Robot tests
  • 5f3e7aa: 8339735: Remove references to Applet in core-libs/security APIs
  • 2ada313: 8340329: (fs) Message of NotLinkException thrown by FIles.readSymbolicLink does not include file name (win)
  • ... and 7 more: https://git.openjdk.org/jdk/compare/8908812d0a64f25f0d033d44725a69348789b223...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@aivanov-jdk
Copy link
Member Author

The test is somewhat similar to #21013, it uses similar synchronisation logic.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 19, 2024
@openjdk
Copy link

openjdk bot commented Sep 19, 2024

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Sep 19, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants